Skip to content

revert: AI inline assistant for SQL editor (PR F)#1088

Merged
datlechin merged 3 commits into
mainfrom
revert/pr-f-bloat
May 7, 2026
Merged

revert: AI inline assistant for SQL editor (PR F)#1088
datlechin merged 3 commits into
mainfrom
revert/pr-f-bloat

Conversation

@datlechin

Copy link
Copy Markdown
Member

Summary

Reverts the inline SQL assistant from #1084 — too much surface area for an experimental feature. ~750 LOC of new code: InlineAssistantSession, InlineAssistantPresenter, InlineAssistantOverlayController, InlineAssistantPromptView, AIEditorContextMenu, prompt templates, plus borderless NSPanel + NSEvent localKeyDown monitor wiring through SQLEditorCoordinator.

The chat panel + per-connection rules + per-mode tool gating (PRs A, B, C, D, G) cover the core AI assistance path. Inline rewrite-in-place adds a second editor surface, a second streaming pipeline, and a custom panel chrome — return on complexity is not yet proven.

What this PR does

  1. Reverts fix: inline assistant + tool registry compile errors #1085 (inline assistant compile-error hotfix) — that fix only mattered for feat: AI inline assistant for SQL editor #1084 code.
  2. Reverts feat: AI inline assistant for SQL editor #1084 (PR F merge) — drops all InlineAssistant* files, the editor coordinator hooks, the AIEditorContextMenu wiring, and the Edit > Rewrite with AI… menu.
  3. Re-applies the nonisolated modifier on ChatToolRegistry.isToolAllowed(name:in:) — that part of fix: inline assistant + tool registry compile errors #1085 was for PR D's tool gating (still in main) and is unrelated to inline assistant. Without it, AIChatViewModel.runToolUse (nonisolated static) cannot call isToolAllowed.

What stays in main

  • PR A layout shell
  • PR B composer rewrite (TextField axis vertical + Apple Intelligence shimmer)
  • PR C code blocks via CodeEditSourceEditor
  • PR D mode-gated tools (Ask / Edit / Agent)
  • PR G per-connection AI rules
  • PR fix: anchor mention popover at composer top-leading #1086 mention popover anchor fix

Test plan

  • Build the project. No InlineAssistant* references remain.
  • SQL editor: select text, press Ctrl+Return. Nothing happens (no panel) — the keybind is no longer captured.
  • Editor context menu has no Rewrite with AI... item.
  • AI Chat panel still works end-to-end: typing, mention popover, code blocks, mode switching, per-connection rules.
  • xcodebuild test -only-testing:TableProTests/ChatToolRegistryModeTests still passes (verifies isToolAllowed reachable from nonisolated context).

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@datlechin datlechin merged commit 6702e41 into main May 7, 2026
2 checks passed
@datlechin datlechin deleted the revert/pr-f-bloat branch May 7, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant